Repository navigation
Don't let TestTryCommittedSequenceTwice hang when the double delivery race doesn't happen - #719
Merged
pfi79 merged 1 commit intoOct 22, 2026
Conversation
pfi79
approved these changes
Oct 21, 2026
HagarMeir
force-pushed
the
fix/try-committed-sequence-twice-hang
branch
from
October 22, 2026 07:04
b5a985d to
b6914ac
Compare
…ppen The test's log hooks on node 4 waited forever for both the controller and the view changer to deliver the same decision. When node 4 decided it through the controller only, the controller blocked in the hook and the test hung until the package timeout. Wait for the other goroutine only for a while, close deliverControlCh at most once, and don't block on twiceDeliverBeginCh once both goroutines signalled. The final check that all nodes delivered the same value is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
pfi79
force-pushed
the
fix/try-committed-sequence-twice-hang
branch
from
October 22, 2026 07:09
b6914ac to
bd88e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic's AI assistant) on behalf of Hagar Meir.
Fixes #718.
The test's log hooks on node 4 waited forever for both the controller and the view changer to deliver the same decision. When node 4 decided it through the controller only, the controller blocked in the hook, and the test hung until the package timeout.
Changes (test only)
deliverControlChis closed at most once.twiceDeliverBeginChdon't block once both goroutines have signalled.The final assertion, that all nodes delivered the same value, is unchanged, so a double delivery or a fork still fails the test.
Testing
-race.mainthe test hung in 1 of 60 runs.mainwith add golangci-lint check #717: 30 of 30 runs passed, the fulltestpackage passed, andgolangci-lint run ./...reports no issues.🤖 Generated with Claude Code