Repository navigation
Restore the requests of a proposal recovered from the WAL - #716
Merged
Merged
Conversation
A view restored from the WAL after a restart had its proposal but not its requests, and no pre-prepare time. So when it decided the proposal, its requests were not removed from the pool, CountTxsAll was not increased, and LatencyBatchProcessing recorded the time since the zero time. Set the view's requests from the verifier and its pre-prepare time when restoring an in-flight proposal, as a view does when it accepts one, and check both in TestViewPersisted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
pfi79
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic's AI assistant) on behalf of Hagar Meir.
Fixes #715.
A view restored from the WAL after a restart had its proposal but not its requests, and no pre-prepare time. So when it decided the proposal, the requests were not removed from the pool,
CountTxsAllwas not increased, andLatencyBatchProcessingrecorded about 292 years. #702 fixed the same gap for the in-flight view.Changes
recoverProposedandrecoverPreparedset the view'sinFlightRequestsfromVerifier.RequestsFromProposal, andbeginPrePrepareto the time of the restore. That's what a view sets when it accepts a proposal, and the WAL doesn't persist it.TestViewPersistednow checks that each decision passes on the proposal's requests and records a reasonable latency, with and without a crash. Onmain, the three crash cases fail.TestStateRestoregives its view a verifier, as every view built byProposalMakerhas.No message or decision rule changes.
🤖 Generated with Claude Code