Repository navigation
Do not panic when the in-flight view complains - #708
Merged
Merged
Conversation
The view that commits the in-flight proposal after a view change uses the view changer as its failure detector, and ViewChanger.Complain panicked. The view complains when it gets a message with a wrong view number from its leader, which for this view is the node itself, and then stops (and syncs if the message is from a newer view) like any other view. There is no reason to crash the node, so log a warning instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
HagarMeir
force-pushed
the
fix/inflight-view-complain
branch
from
October 18, 2026 09:48
12ab08f to
cb49e94
Compare
pfi79
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic's AI assistant) on behalf of Hagar Meir.
Fixes #707.
The view that commits the in-flight proposal after a view change uses the view changer as its failure detector, and
ViewChanger.Complainpanicked. The view complains when it gets a message with a different view number from its leader. For this view, the leader is the node itself. After complaining, the view stops, and it syncs if the message is from a newer view, like any other view. So nothing requires crashing the node.Changes
ViewChanger.Complainlogs a warning instead of panicking.TestInFlightViewMessageFromItselfWithWrongViewstarts the in-flight view and delivers it a commit for a newer view, with the node's own ID as the sender. It checks that the node doesn't panic, and that the view stops and syncs. Onmainit panics.🤖 Generated with Claude Code