Repository navigation
Ignore a NewView message for a view the node already installed - #704
Merged
HagarMeir merged 1 commit intoOct 18, 2026
Merged
Conversation
pfi79
approved these changes
Oct 15, 2026
Contributor
|
@HagarMeir need a rebase |
HagarMeir
force-pushed
the
fix/ignore-duplicate-newview
branch
from
October 18, 2026 07:08
03cceb1 to
57ba23d
Compare
A NewView message for the view the node is already in was processed again from the start, repeating the view installation: the in-flight check, the WAL record, ViewChanged and the timer restarts. When the in-flight proposal had already been decided and the node had moved past it, commitInFlightProposal panicked. Keep a flag recording that a NewView was accepted for the current view, set when the view is installed or the node is informed of it, cleared when a view change moves to the next view, and ignore NewView messages while it is set. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
HagarMeir
force-pushed
the
fix/ignore-duplicate-newview
branch
from
October 18, 2026 07:14
57ba23d to
6d6dac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic's AI assistant) on behalf of Hagar Meir.
Fixes #703.
A NewView message for the view a node is already in was processed again from the start. That repeats the whole view installation: the WAL record,
ViewChanged, the timer restarts, and the in-flight check. When the in-flight proposal was already decided and the node had moved past it, it ended in a panic incommitInFlightProposal.Changes
ViewChangerkeepsacceptedNewView:processNewViewMsginstalls the view, and wheninformNewViewmoves the node to a view;processMsgignores a NewView while the flag is set.TestNewViewOfCurrentViewIsIgnoredsends the same NewView twice, once without and once with an in-flight proposal, and checks that the view is installed once. Onmain, the first case callsViewChangedtwice, and the second panics.A NewView that didn't install the view still leaves the next one to be processed as before. No message changes.
🤖 Generated with Claude Code