Skip to content

Add DefaultPostgreSQLProviderFeatures with the 65535 placeholder limit #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnriqueL8 merged 2 commits into from
Oct 26, 2026
+24 −0
Merged

Add DefaultPostgreSQLProviderFeatures with the 65535 placeholder limit #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d496461
add default PostgreSQL provider features with the 65535 placeholder l…
Chengxuan Oct 2, 2026
7c73deb
update comment
Chengxuan Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/dbsql/postgres_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@ import (
"github.com/hyperledger-firefly/common/pkg/i18n"
)

// PostgreSQLMaxPlaceholders is the limit on bind parameters in one statement, set by the PostgreSQL wire protocol
const PostgreSQLMaxPlaceholders = 65535

// DefaultPostgreSQLProviderFeatures are the features suggested for all PostgreSQL providers, clients can add their own on top
func DefaultPostgreSQLProviderFeatures() SQLFeatures {
features := DefaultSQLProviderFeatures()
features.PlaceholderFormat = sq.Dollar

@EnriqueL8 EnriqueL8 Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a change in behaviour by default?

@Chengxuan Chengxuan Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. Everything in this function is not picked up automatically. It provides a template that can be used to build the sql feature in the client code.

features.MultiRowInsert = true
features.MaxPlaceholders = PostgreSQLMaxPlaceholders
features.DBOptimizedUpsertBuilder = BuildPostgreSQLOptimizedUpsert
return features
}

// BuildPostgreSQLOptimizedUpsert is a PostgreSQL helper to avoid implementing this lots of times in child packages
func BuildPostgreSQLOptimizedUpsert(ctx context.Context, table string, idColumn string, insertCols, updateCols []string, returnCol string, values map[string]driver.Value) (insert sq.InsertBuilder, err error) {
insertValues := make([]interface{}, 0, len(insertCols))
Expand Down
11 changes: 11 additions & 0 deletions pkg/dbsql/postgres_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"database/sql/driver"
"testing"

sq "github.com/Masterminds/squirrel"
"github.com/hyperledger-firefly/common/pkg/fftypes"
"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -60,3 +61,13 @@ func TestBuildPostgreSQLOptimizedUpsertFail(t *testing.T) {
assert.Regexp(t, "FF00247", err)

}

func TestDefaultPostgreSQLProviderFeatures(t *testing.T) {

features := DefaultPostgreSQLProviderFeatures()
assert.Equal(t, sq.Dollar, features.PlaceholderFormat)
assert.True(t, features.MultiRowInsert)
assert.Equal(t, 65535, features.MaxPlaceholders)
assert.NotNil(t, features.DBOptimizedUpsertBuilder)

}
Loading