fix: Account for connection flow control on DATA after GOAWAY#895
Open
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Open
fix: Account for connection flow control on DATA after GOAWAY#895ArniDagur wants to merge 1 commit intohyperium:masterfrom
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Conversation
See: * Golang: https://github.com/golang/net/blob/0a81d5af911d6b2c1ad6c271c6aa2fe09747fd75/http2/server.go#L1440-L1453 * nghttp2: https://github.com/nghttp2/nghttp2/blob/1f8481251cb28848b45d950de6cad6a1311eedf5/lib/nghttp2_session.c#L6935-L6960 When h2 sends GOAWAY and then receives DATA on a stream above the GOAWAY `last_stream_id`, the data is correctly ignored, but flow control capacity is leaked at the connection level. This can cause an issue with streams lower than `last_stream_id` being stalled forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
When h2 sends GOAWAY and then receives DATA on a stream above the GOAWAY
last_stream_id, the data is correctly ignored, but flow control capacity is leaked at the connection level. This can cause an issue with streams lower thanlast_stream_idbeing stalled forever.