fix: WINDOW_UPDATE 0-increment RFC conformance#892
Open
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Open
fix: WINDOW_UPDATE 0-increment RFC conformance#892ArniDagur wants to merge 1 commit intohyperium:masterfrom
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Conversation
a12ed50 to
62f963d
Compare
62f963d to
235c244
Compare
Member
|
Do you mind mentioning what you hope to unlock? From the looks of the code, it will already return an error, right? Just that it's a connection error instead of stream? |
Contributor
Author
|
This came from an audit of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
h2emitted a connection levelGOAWAY(PROTOCOL_ERROR)when a peer sent aWINDOW_UPDATEframe with an increment of zero, regardless of which stream the bad frame was on. This killed every stream on the connection. Instead, we should only reset that particular stream.This is described in https://www.rfc-editor.org/rfc/rfc9113.html#section-6.9-9
See: