Skip to content

fix: WINDOW_UPDATE 0-increment RFC conformance#892

Open
ArniDagur wants to merge 1 commit intohyperium:masterfrom
ArniDagur:fix/window-update-zero-increment-stream-error
Open

fix: WINDOW_UPDATE 0-increment RFC conformance#892
ArniDagur wants to merge 1 commit intohyperium:masterfrom
ArniDagur:fix/window-update-zero-increment-stream-error

Conversation

@ArniDagur
Copy link
Copy Markdown
Contributor

@ArniDagur ArniDagur commented Apr 27, 2026

Previously, h2 emitted a connection level GOAWAY(PROTOCOL_ERROR) when a peer sent a WINDOW_UPDATE frame with an increment of zero, regardless of which stream the bad frame was on. This killed every stream on the connection. Instead, we should only reset that particular stream.

This is described in https://www.rfc-editor.org/rfc/rfc9113.html#section-6.9-9

See:

@ArniDagur ArniDagur force-pushed the fix/window-update-zero-increment-stream-error branch from a12ed50 to 62f963d Compare April 27, 2026 17:22
@ArniDagur ArniDagur force-pushed the fix/window-update-zero-increment-stream-error branch from 62f963d to 235c244 Compare April 27, 2026 17:23
@seanmonstar
Copy link
Copy Markdown
Member

Do you mind mentioning what you hope to unlock? From the looks of the code, it will already return an error, right? Just that it's a connection error instead of stream?

@ArniDagur
Copy link
Copy Markdown
Contributor Author

This came from an audit of h2 for bugs, by comparing against Golang / nghttp2. This is not a big issue as clients shouldn't be sending these zero increment updates, but it's technically RFC non-conformant, and also kills all streams rather than just the specific one.

@ArniDagur ArniDagur changed the title wip fix: WINDOW_UPDATE 0-increment RFC conformance Apr 27, 2026
@ArniDagur ArniDagur marked this pull request as ready for review April 27, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants