Repository navigation
Conversation
createSDKContext takes an optional didResolver (a DidResolver or oauthClient.identityResolver). Without one, each context gets its own cached resolver instead of a new uncached one per lookup. Adds @atproto-labs/identity-resolver as a dev dependency to type-test the oauth shape.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🦋 Changeset detectedLatest commit: 369aa14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
❌ The last analysis has failed. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SDK looked up a DID document on every call with a fresh, uncached resolver, so each operation hit plc.directory again. Apps that already have a resolver (for example
oauthClient.identityResolver, which caches) had no way to hand it to the SDK.Fix
createSDKContext({ client, didResolver? }): new optionaldidResolver, typed asDidDocumentResolver. Accepts an@atproto-labs/did-resolverresolver oroauthClient.identityResolver.fetchat request time, so tests that stub fetch still work.oauthClient.identityResolver; minor changeset.