Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🦋 Changeset detectedLatest commit: 1e88cc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| export const creatorOf = | ||
| <TInput extends { createdAt?: string | undefined }, TResult>( | ||
| operation: string, | ||
| kind: RecordKind<TInput>, | ||
| ): StandaloneCreator<TInput, TResult> => | ||
| (context, input) => | ||
| createRecordTree(context, operation, kind, input); |
There was a problem hiding this comment.
(reply generated by Claude Sonnet via pi)
Reviewed the semantic match (jscpd --semantic, report-only in CI) against createStandalone / createRecordTree in internal/create-record.ts. Not a real duplicate: creatorOf is a curried adapter that binds an operation name and a RecordKind to createRecordTree and keeps the full result tree (TResult), while createStandalone takes all four arguments at once and discards the tree to return only { uri, cid }. They share the call to createRecordTree and a generic signature, and nothing else that could be factored out. Leaving as-is; leaving the thread open for the maintainer to confirm.
1875d30 to
e1c35b0
Compare
e1c35b0 to
802ed60
Compare
…ent creators
Adds createAttachment, createMeasurement, createEvaluation and createAcknowledgement at @hypercerts-org/sdk/context. New locations, tags and measurements are created in the same applyWrites as the record that points at them; existing { uri } records are reused unchanged. Attachment description is string-only until the shared long-description helper lands.
802ed60 to
1e88cc1
Compare
|
❌ The last analysis has failed. |
Closes TECH-754.
Adds
@hypercerts-org/sdk/context:createAttachment,createMeasurement,createEvaluationandcreateAcknowledgement(org.hypercerts.context.*).Changes
{ uri }, like the rest of the SDK.{ uri }come once the shared description helper (TECH-761) is on main.