Repository navigation
Push the validated release tag from the Release workflow - #109
Conversation
The Changesets v2 migration set push-git-tags to false, and scripts/release.mjs only tags the runner's checkout, so the v0.10.0 release run created and validated its tag without publishing it. Push the tag after validation, refusing a tag that does not resolve to the checked-out release commit. A plain push never moves an existing tag. This work was assisted by a machine
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|



Problem
Release run 43204598614 for v0.10.0 succeeded. Its log says
Created git tags: v0.10.0andcomponent versions match v0.10.0, but the tag never reached GitHub.The cause is 9441285, the Changesets v2 input rename, which set
push-git-tags: 'false'.scripts/release.mjs(changeset git-tag) only tags the runner's checkout. Neither the merge-triggered path nor thetag_current_versiondispatch path pushes the tag. v0.10.0 is the first release since that change.Change
v<package version>resolves to the checked-out release commit, then pushes only that tag. It doesn't force, so an existing tag on GitHub is never moved.RELEASING.mdnow says the workflow pushes the validated tag.The checkout already keeps the release bot token (
persist-credentials: true), and the job hascontents: write.Verification
actionlint1.7.7 passes onrelease.ymlgit diff --checkis cleanv0.10.0 itself is being tagged separately at the merged release commit
e5cf67f4, which the run above validated. No changeset is included because this changes only release automation.🤖 Generated with Claude Code
Summary by CodeRabbit