Repository navigation
Conversation
- Run each deployment profile as its own matrix job; fan-in job runs assert-resilience-profiles on the uploaded receipts. - Run worker-takeover beside journey and cross-node-signin (default 120s lease kept). - Run the SQLite and PostgreSQL contract suites concurrently; the PostgreSQL restart/restore profile reuses the databases job sandbox.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI takes about 13 minutes. The three resilience profiles run one after another in one job,
worker-takeoverwaits out a real 120s lease with nothing else running, and the databases job runs its two suites serially and builds a second sandbox.Fix
profiles (<profile>)).profiles (assert all receipts)downloads the receipts and runsassert-resilience-profiles. The requiredprofilescheck is replaced by these four names.worker-takeoverruns besidejourneyandcross-node-signin, before any fault step. The 120s lease is unchanged.POSTGRESQL_PROFILE_REUSE_SANDBOX=1).