Repository navigation
build(lints): allow clippy::assert_is_empty from Rust 1.99 - #10
Merged
Merged
Conversation
Rust 1.99.1 added assert_is_empty to the pedantic group, which this crate denies, so CI broke on ten existing `assert!(v.is_empty())` checks without any code change. Clippy's suggested fix rewrites them as `assert_eq!(v, [] as [Type; 0])`, which is harder to read, so the lint joins the other pragmatic style allowances. Co-Authored-By: Nova (Claude Opus 5.5) <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 51 minutes for your next included review. View limit details
CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainhas been red since Rust 1.99.1 (2026-10-13). That release addedclippy::assert_is_emptyto the pedantic group, and this crate denies pedantic, so ten existingassert!(v.is_empty())checks in tests now failci / checkwith no code change. The last greenmainrun was on 2026-09-07; #9 hit the same failure on a YAML-only diff.Clippy's suggested fix turns each check into
assert_eq!(v, [] as [Type; 0]), which reads worse than what it replaces and needsPartialEqon types that don't otherwise want it. So this adds the lint to the existing block of pragmatic style allowances inCargo.toml, next tomust_use_candidate.🧪 Validation
ci / checkon this PR is the proof: it runs the same stable 1.99.1 clippy with-D warningsthat failed #9.