Pretty-print Hyperaudio JSON and drop legacy import path#300
Open
maboa wants to merge 1 commit into
Open
Conversation
- JSON.stringify with two-space indentation so exported files are readable and diffable instead of a single long line. - Remove the legacyJsonToHtml function and the jsonData.article fallback in jsonToHtml — anyone holding an old export can re-export from a recent build. - Drop the jsonData.url top-level back-compat in importJson; media URL is sourced exclusively from sections[0].mediaUrl now. Closes #298.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to #297:
downloadJsonnow callsJSON.stringify(jsonData, null, 2)so exported files are indented and readable instead of one long line.legacyJsonToHtmlfunction, thejsonData.articlefallback injsonToHtml, and thejsonData.urlback-compat inimportJson. Anyone holding an old export can re-export from a recent build.Closes #298.
Test plan
article.section.paragraphs[].spans[]) → either fails or imports as empty, no crash.