Skip to content

fix: give review turns four minutes before the action's end - #41

Merged
hyochan merged 1 commit into
mainfrom
fix/review-turn-timeout
Nov 18, 2026
Merged

hyochan merged 1 commit into
mainfrom
fix/review-turn-timeout

Conversation

@hyochan

@hyochan hyochan commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

The last main-loop turn of a GPT-6.2 Sol review, the one that writes its findings, can take over two minutes. In production at 01:01 (2026-11-19), pr-review/7 was cut off at exactly 120 seconds. The attempt became ambiguous, and the account's AI work was blocked for 30 minutes.

  • Every review request now waits up to four minutes by default, still capped by the action's nine-minute end time, which the provider enforces when the request is sent.
  • Requests that set their own timeout keep it: late passes take two to four minutes, and the closing synthesis two to five.
  • A request with under 30 seconds left (90 for slow phases) is still not sent, so the review fails cleanly instead of blocking the account.

Verification

  • bun run lint, bun run typecheck, bun run build, bunx prettier --check .
  • bun run test: 2110 passed, including a main turn carrying the four-minute timeout and the end time

🤖 Generated with Claude Code

@gitdogai

gitdogai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Review not completed for 748bbef

Gitdog could not complete the review. Comment @gitdogai review to try again.

@hyochan
hyochan merged commit 1916d83 into main Nov 18, 2026
7 checks passed
@hyochan
hyochan deleted the fix/review-turn-timeout branch November 18, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant