Skip to content

feat: record how each pull request review ran - #36

Merged
hyochan merged 3 commits into
mainfrom
feat/review-records
Nov 18, 2026
Merged

hyochan merged 3 commits into
mainfrom
feat/review-records

Conversation

@hyochan

@hyochan hyochan commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

Records how each pull request review ran, so review quality can be measured instead of assumed.

  • New reviewRecords table, one row per model run of a review (each group of a batched review is its own row):
    • the provider, model and key source (Gitdog or the owner's own key), and duration;
    • files changed, inspected and left uncovered, and the discussion entries read;
    • the steps run, candidates proposed and discarded, findings kept and open requests;
    • outcome proposed or failed. A failed run is recorded once a model was chosen.
  • A bounded per-step trace records what each step proposed (path, priority, confidence, title) and what verification kept or discarded:
    • at most 24 steps and 30 entries per step, with titles capped at 200 characters;
    • a daily cron (trim-review-traces) clears it after 30 days, and the counts stay.
  • Writing a record never fails a review.
  • Disconnecting a repository deletes its review records, through a new review_records cleanup phase that the final check also covers.
  • Privacy policy (en/ko/ja):
    • "How we use" gains measuring and improving review quality;
    • "Data retention" gains review records while the repository is connected, and candidate titles and paths for 30 days.
  • Terms 6.2 (en/ko/ja) says these records are kept to measure review quality, and that content is not sold or used to train Gitdog's own models.
  • The "Last updated" dates move to November 18, 2026. The acceptance version stays unchanged: bumping it would pause every owner's automatic reviews until they accept again, and this update adds no new obligation for users.
  • For comparison, CodeRabbit keeps review caches for 7 days, and Copilot keeps prompts and suggestions for 28 days.

Verification

  • bun run lint, bun run typecheck, bun run build
  • bun run test: 2091 passed, including:
    • a new record and trace-trim test;
    • a failed-run record;
    • disconnect cleanup of review records.
  • bun run test:cli: 114 passed; bun run check:api: 93 functions match

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit f2f3360):

https://codeyou-df251--pr36-feat-review-records-n706t06f.web.app

(expires Wed, 25 Nov 2026 08:32:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5

gitdogai[bot]
gitdogai Bot previously approved these changes Nov 18, 2026

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in c41abc8

Approved because no issues were found in fully reviewed changes. Tests were not run. Gitdog

@hyochan
hyochan force-pushed the feat/review-records branch from c41abc8 to f2f3360 Compare November 18, 2026 08:31
@gitdogai
gitdogai Bot dismissed their stale review November 18, 2026 08:31

New commits were pushed after the commit Gitdog approved. Comment @gitdogai review to review them.

@hyochan hyochan left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review findings from an independent Opus review of this branch.

Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/internalMutation.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/records.ts Resolved
Comment thread convex/pullRequests/records.ts Resolved
Comment thread src/i18n/locales/en.json Resolved
@hyochan

hyochan commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

@gitdogai review

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in f2f3360

Approved because no issues were found in fully reviewed changes. Tests were not run. Gitdog

@hyochan
hyochan merged commit 7d2cab4 into main Nov 18, 2026
9 checks passed
@hyochan
hyochan deleted the feat/review-records branch November 18, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant