Repository navigation
fix: one review result, and reviews that read the conversation - #34
Merged
Merged
Conversation
A posted review is the result, so its status comment is now deleted instead of repeating it as "Reviewed". A single review also reads the pull request conversation (comments, review summaries and unresolved threads, bounded and without Gitdog's own posts) and lists each change a reviewer asked for that the code does not make yet. A clean review no longer approves while such a request, an unresolved thread from anyone, or a reviewer's standing request for changes remains.
…eir own A review that lists open requests now withdraws an earlier Gitdog approval like one with findings. An open request counts only if it shares wording with what that reviewer wrote, and only as one line of plain text without links or cross-references. The discussion reads the newest conversation page and the last hundred threads, puts people ahead of bots, keeps short requests, and drops only the command line of a comment. Publish skips thread reads that cannot change the outcome, and verification-only reviews do not read the discussion.
Open requests are asked for in the reviewer's own words so the wording check holds, and one failed GitHub read no longer drops the other parts of the discussion.
|
Review cancelled for 541ce1d The pull request changed or was closed before the review finished. |
hyochan
commented
Nov 18, 2026
|
Visit the preview URL for this PR (updated for commit 541ce1d): https://codeyou-df251--pr34-fix-one-review-resul-4fw9npuu.web.app (expires Wed, 25 Nov 2026 05:46:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a pull request in a connected repository:
What changes
deleteIssueComment; a 404 counts as done). The comment still shows reviewing, waiting for approval, failures and no-change results, where no review exists.A review that lists open requests also withdraws an earlier Gitdog approval, as findings do.
openRequests, listed under "Not yet addressed from the discussion". Such a review waits for approval like one with findings.Production impact
proposedChangesis untyped.Verification
bun run lint,typecheck,build,test(2090 tests),format:check,check:api,typecheck:cli,test:cliFable confirmed the head clean.
🤖 Generated with Claude Code