Repository navigation
feat: review open pull requests when reviews turn on - #33
Merged
Merged
Conversation
Reviews start on pull request events, so a pull request opened before reviews were on, or before the repository was connected, never got one. Turning pull request reviews on, or reactivating or reconnecting a repository with them on, now reviews up to five open pull requests updated in the last 30 days, ten minutes apart, skipping drafts and bot pull requests. Each still gets only its first review.
…requests A project key turning reviews on patched settings inline and never scheduled the catch-up; it now shares one helper with the web settings, reactivation, reconnect and GitHub access restore. The helper runs at most once an hour per repository. The catch-up skips pull requests that already have a review, malformed list entries, and accounts with no tokens and no usable key of their own, and spaces reviews 12 minutes apart.
|
Reviewed 4d20e7c · see the review |
|
Visit the preview URL for this PR (updated for commit 4d20e7c): https://codeyou-df251--pr33-feat-review-open-prs-grf2lh0a.web.app (expires Wed, 25 Nov 2026 02:32:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviews start on pull request events, so a pull request opened before reviews were on never gets reviewed. hyochan/react-native-nitro-sound#857 was opened on 2026-10-23, before that repository was connected on 2026-11-04, and Gitdog never saw an event for it.
What changes
When pull request reviews turn on, up to five open pull requests updated in the last 30 days that were never reviewed get their first review. "Turn on" covers:
The limits:
repositories.pullRequestCatchUpAt);Each pull request still goes through the same
observepath as a webhook: the first-review rule, bot checks, legal eligibility and settings all apply.Production impact
repositories.Verification
bun run lint,typecheck,build,test(2080 tests),format:check,check:api,typecheck:cli,test:cli🤖 Generated with Claude Code