Skip to content

feat: show review progress on the pull request and accept @gitdog - #28

Merged
hyochan merged 4 commits into
mainfrom
fix/command-aliases-and-failure-notices
Nov 17, 2026
Merged

hyochan merged 4 commits into
mainfrom
fix/command-aliases-and-failure-notices

Conversation

@hyochan

@hyochan hyochan commented Nov 17, 2026

Copy link
Copy Markdown
Member

Summary

On hyodotdev/openiap#619 Gitdog was reviewing all along (a 255-file batched review), but nothing on the pull request said so, and the @gitdog review comment was ignored. This PR fixes both.

Review progress on the pull request

  • Each review keeps one status comment, posted when the review starts reading code ("Reviewing · N changed files") and edited as it moves: ready for approval, reviewed (with a link), no new changes, cancelled by a newer push, or not completed with a reason.
  • Reasons are safe for public pull requests: the owner's own provider key state is never shown ("the AI provider settings of the account that connected this repository need attention"), and an unconfirmed post tells readers to check the reviews above.
  • This replaces the separate once-a-day limit notice and the no-change reply; a command that starts a review no longer posts its own "Review started" reply, since the status comment answers it.
  • Failures before a status comment exists still post one (a failure or a no-change result); rechecks and cancelled reviews without a comment post nothing.

Commands

  • @gitdog works as shorthand for @gitdogbot (the docs note it also notifies the GitHub user of that name).
  • A command may follow another review bot's command on the same line: @coderabbitai review @gitdogbot review. The preceding mention must look like a bot (…bot, …ai, copilot, …assist, [bot]), so "@alice I think @gitdogbot review is broken" still does not run one.

Production impact

  • Schema: optional ticketActions.statusCommentId. tickets.pullRequestLimitNoticeAt stays in the schema but is no longer written.
  • Cost: one issue comment per review plus one edit when it ends. No billing, auth or GitHub App permission change (issue comments already need issues: write).

Test plan

  • bun run lint && bun run typecheck && bun run build && bun run test && bun run format:check && bun run check:api && bun run typecheck:cli && bun run test:cli
  • Tests: alias and chained parsing (including the sentence case), the reviewing comment posted once, edits in place, safe failure reasons, limit wording, and no comment for rechecks or cancelled reviews
  • Production: a test PR shows Reviewing, then Reviewed; @gitdog review works

🤖 Generated with Claude Code

Each review keeps one status comment on the pull request: reviewing when
it starts, then ready for approval, reviewed with a link, no new changes,
cancelled, or why it could not finish, with reasons safe for public pull
requests. This replaces the separate limit and no-change notices. Commands
also run as @GitDog and after another review bot's command on the same
line.
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit e9964c6):

https://codeyou-df251--pr28-fix-command-aliases-w2bxo47g.web.app

(expires Tue, 24 Nov 2026 17:34:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in eef23f8

6 of 11 changed files were not fully reviewed.

Not a merge approval. Tests were not run. Gitdog

…ands

Status comments change only on outcomes: an expiry that ended nothing, a
running review and a review about to post leave them alone, a late settle
re-reads the review before editing, and rejection, a recheck supersede, an
approval-setting change and a review that ended before its comment was
recorded all update it. A pull request that keeps failing hears about
automatic reviews at most once a day, cancellations read as cancelled, and
an oversized pull request gets no retry hint. A chained command must follow
a known review bot, a chained thank-you posts nothing, and @GitDog belongs
to the production app only.

@hyochan hyochan left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 issues found in the first review round

Independent Opus 5.5 and Fable reviews found the issues below. All are fixed in 2d08b47.

Posted in Gitdog's review format. Gitdog

Comment thread convex/pullRequests/internalMutation.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/internalMutation.ts Resolved
Comment thread convex/pullRequests/internalMutation.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
…c reviews

Stored failure messages are rewritten for display, so matching them never
detected a cancelled review. Generation and publication now record
reviewCancelled when the pull request moved on, and a cancelled request
still offers a retry. An automatic failure that edits its existing comment
starts the daily quiet window too, settle decides before fetching a GitHub
token, a settle-posted comment no longer triggers a second settle, and a
first review with nothing reviewable says so instead of reporting no new
changes. Chained full requires review, the help text offers @GitDog only in
production, and Cursor and Codium are known review bots.

@hyochan hyochan left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found in the second review round

All are fixed in a3cc0f6.

Posted in Gitdog's review format. Gitdog

Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/errors.ts Resolved
Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/internalMutation.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
Nothing is posted until the review request goes out, so a lifecycle
change after the claim is a cancellation, not a GitHub failure. Also
drop binary files from the nothing-to-review wording, since a
binary-only pull request never reaches it.

@hyochan hyochan left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues in a3cc0f6, both fixed in e9964c6

Not a merge approval. Tests were not run. Gitdog

Comment thread convex/pullRequests/internalAction.ts Resolved
Comment thread convex/pullRequests/commands.ts Resolved
@hyochan
hyochan merged commit b9b4991 into main Nov 17, 2026
8 of 9 checks passed
@hyochan
hyochan deleted the fix/command-aliases-and-failure-notices branch November 17, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant