Skip to content

fix(deps): update vulnerable shell-quote - #10

Merged
hyochan merged 2 commits into
mainfrom
bugfix/secure-shell-quote
Nov 21, 2026
Merged

hyochan merged 2 commits into
mainfrom
bugfix/secure-shell-quote

Conversation

@hyochan

@hyochan hyochan commented Nov 21, 2026

Copy link
Copy Markdown
Member

The lockfile installs shell-quote 1.10.0 through react-devtools-core, within the range affected by GHSA-pqg4-j6r4-53mv. Refresh that single transitive resolution to published stable 1.12.0, which includes the maintainer's 1.11.0 fix and satisfies the existing ^1.6.1 range. package.json, direct dependencies, overrides, native modules and app/backend sources remain unchanged.

Verification:

  • PASS frozen copyfile install with existing patch/postinstall checks, lint:all, typecheck and coverage: 227 suites / 1,751 passed / 15 existing skips.
  • PASS safe advisory regression probe through the actual react-devtools-core dependency resolver: old version accepts all four post-comment line terminators; fixed version rejects all four as TypeError. Two benign quote/parse round trips pass on both versions. No generated shell command was executed.
  • PASS before/after production-mode exports with QA identity: all 190 iOS and 194 Android files, including Hermes bytecode and source maps, are byte-identical. Neither shell-quote nor react-devtools-core occurs in 3,801 iOS / 3,893 Android mapped sources. These are export comparisons, not signed candidates or device QA.
  • Scoped audit PASS: shell-quote removed and critical count 1→0. Overall audit remains FAIL for 44 existing advisory entries across 11 other packages (20 high, 16 moderate, 8 low); follow-up triage is recorded without suppression or wholesale upgrades.
  • Exact-head history/budget CI and two five-minute-separated clean self-review snapshots are required before integration. N/A native/device/purchase/performance gates: this is a developer-tool dependency with no production bundle/native/backend change. No OTA/store release is needed.

The tracked STATUS records the current batch, existing successful delivery and next resume point. Authenticated Patch readback recovered zero Production releases on both platforms; no build/upload/release was started. Keep the daily coordinator and existing deployment path unchanged.

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bookoo-public Ready Ready Preview Nov 21, 2026 12:10am UTC

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in aad1d27

1 of 2 changed files was not fully reviewed.

Not a merge approval. Tests were not run. Gitdog

@hyochan

hyochan commented Nov 21, 2026

Copy link
Copy Markdown
Member Author

Self-review stability complete for 3e85954ec561c0ddb527c431c65770ee6499d11c / tree d29e319501eaecae5810269f5264b8585d58d2cf.

  • Two CLEAN self-review snapshots: 2026-11-21T00:19:46.917739+00:00 and 2026-11-21T00:26:37.389288+00:00, at least 300 seconds apart, zero actionable in-scope findings or unresolved review threads. This is self-review, not a claim of independent coverage. The handoff wording findings were fixed before these final rounds; no external reviewer was requested.
  • PASS final exact-head CI: https://github.com/hyodotdev/BooKoo/actions/runs/44842077988 — lint/typecheck/coverage tests, complete-history secrets, anonymous 100k transaction budgets and required child success marker. Superseded initial-head CI was cancelled, not counted as final coverage.
  • PASS frozen install/patch checks; local coverage 227 suites / 1,751 passed / 15 existing skips; real-consumer quote probe rejects all 4 post-comment line terminators and preserves 2 benign round trips. No shell payload was executed.
  • PASS production boundary: QA-identity production-mode exports are byte-identical across all 190 iOS / 194 Android output files, including Hermes and source maps; DevTools/selected dependency absent from mapped production sources. No native/runtime/backend source changes; native/device/purchase/performance gates N/A for this scope, with evidence rather than a waiver. No OTA/store delivery needed.
  • Scoped advisory is fixed and audit critical count is 0. Overall audit remains FAIL with 44 baseline advisory entries across 11 other packages, queued for separate reachability/compatibility triage. Do not interpret this clean scoped review as a globally clean dependency audit.
  • SSOT/KISS: upstream escaping implementation and parent ^1.6.1 range preserved; final package.json byte-identical, only one lock record changes; no new direct dependency, persistent override or app-side duplicate.

Ready for strict nonforce fast-forward after a final canonical main/protection/head readback. Exact-main CI/backend deployment still must be verified afterwards. Daily automation remains active; no additional schedule or release was created.

@hyochan
hyochan merged commit 3e85954 into main Nov 21, 2026
6 checks passed
@hyochan
hyochan deleted the bugfix/secure-shell-quote branch November 21, 2026 00:27
@hyochan

hyochan commented Nov 21, 2026

Copy link
Copy Markdown
Member Author

Completed the first daily maintenance cycle; PR #10 merged by strict nonforce fast-forward at 3e85954ec561c0ddb527c431c65770ee6499d11c (2026-11-21T00:27:04Z).

  • Functional fix commit: aad1d27; final handoff clarification: 3e85954. Only bun.lock and the existing STATUS changed. package.json, native/backend/app sources and marketing version 1.5.0 are unchanged.
  • PASS exact-main CI and production Convex automatic deployment: https://github.com/hyodotdev/BooKoo/actions/runs/44843895546. History secrets, source verification, isolated 100k budgets and explicit child success marker passed. No duplicate manual deploy.
  • PASS final PR CI: https://github.com/hyodotdev/BooKoo/actions/runs/44842077988. Self-review CLEAN snapshots 2026-11-21T00:19:46.917739+00:00 / 2026-11-21T00:26:37.389288+00:00 cover the same head/tree, >300 seconds apart, with zero actionable in-scope findings/unresolved threads. No independent review coverage is claimed or external reviewer requested.
  • PASS local frozen copyfile install with original patches/postinstall; lint:all; typecheck; coverage 227 suites / 1,751 passed / 15 existing skips. Safe real-consumer security probe: rejection 0/4→4/4 for post-comment terminators; benign round trips 2/2 on both versions; no generated command executed.
  • PASS production boundary: all 190 iOS / 194 Android production-mode QA-identity export files were byte-identical before/after, including Hermes and source maps, with no selected dependency/DevTools module in production maps. These were export comparisons, not signed candidates/device QA. Runtime inputs remain identical after integration. No new native build, OTA, store submission, rollout, forced-update floor, migration or data deletion. Native/device/purchase/performance and post-client-rollout smoke N/A; no live app smoke or production error-metric claim is made. No recovery was required.
  • Scoped advisory fixed: shell-quote 1.10.0→1.12.0 within the parent's ^1.6.1 range, critical count 1→0. Overall audit still FAIL: 44 baseline advisory entries across 11 other packages (20 high, 16 moderate, 8 low); queued for separate reachability/compatibility triage, without suppressions or blanket security claims.

Delivery recovery: existing Codemagic/Patch credentials work; latest observed Codemagic dry run 6afe8cca799fbd143cea904c finished, and authenticated Patch Production lists total=0 for both BooKoo-iOS and BooKoo-Android. No build/tag/release was restarted. Existing iOS 1.5.0/build60 public state retained; Android public listing 1.5.0 retained, with authenticated exact versionCode/internal-track readback still PENDING before a future native-release decision.

Daily automation bookoo remains ACTIVE at 09:00 Asia/Seoul in this public worktree/chat. No new schedule or recursive runner. Resume via tracked STATUS plus this PR/check record: triage the remaining audit packages by actual call paths and compatibility, one bounded bundle at a time, and recover any newly pending release before dependent work. No owner decision needed for this completed developer-tool fix.

Owned raw export/Metro temporary outputs were removed after retaining comparison hashes, audit and probe evidence on DevLogs. Portable caches/mappings and original ops checkout were preserved; the public worktree remains available for scheduled runs. This comment is the final exact-SHA/deployment record, avoiding a recursive SHA-only source commit.

This branch was successfully deployed

2 active deployments
Production — 3e85954e Deployed Nov 21, 2026 by vercel[bot]
Preview — 3e85954e Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant