Skip to content

fix(judge): treat empty output files as existing #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ujimatsu-Chiya wants to merge 1 commit into from
+7 −5
Closed

fix(judge): treat empty output files as existing #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/hydrojudge/src/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,15 @@
const outname = params.filename ? `${params.filename}.out` : 'stdout';
ret.files = result.files || {};
ret.fileIds = result.fileIds || {};
if (ret.fileIds[outname]) ret.fileIds.stdout = ret.fileIds[outname];
if (params.filename && !ret.fileIds[outname] && !ret.files[outname]) {
const hasOutputFileId = Object.prototype.hasOwnProperty.call(ret.fileIds, outname);

Check failure on line 139 in packages/hydrojudge/src/sandbox.ts

View workflow job for this annotation

GitHub Actions / build 

Use Object.hasOwn() instead of hasOwnProperty
const hasOutputFile = Object.prototype.hasOwnProperty.call(ret.files, outname);

Check failure on line 140 in packages/hydrojudge/src/sandbox.ts

View workflow job for this annotation

GitHub Actions / build 

Use Object.hasOwn() instead of hasOwnProperty
if (hasOutputFileId) ret.fileIds.stdout = ret.fileIds[outname];
if (params.filename && !hasOutputFileId && !hasOutputFile) {
result.error = 'Output file not found';
ret.status = STATUS.STATUS_RUNTIME_ERROR;
}
ret.stdout = ret.files[outname] || '';
ret.stderr = ret.files.stderr || result.error || '';
ret.stdout = ret.files[outname] ?? '';
ret.stderr = ret.files.stderr ?? result.error ?? '';
if (result.error) ret.error = result.error;
return ret;
}
Expand Down Expand Up @@ -250,4 +252,4 @@
return true;
}

export * from './sandbox/interface';
export * from './sandbox/interface';

Check failure on line 255 in packages/hydrojudge/src/sandbox.ts

View workflow job for this annotation

GitHub Actions / build 

Newline required at end of file but not found
Loading