Skip to content

ui: fix user select dialog change#1184

Merged
undefined-moe merged 1 commit into
masterfrom
fix-user-select
Jun 23, 2026
Merged

ui: fix user select dialog change#1184
undefined-moe merged 1 commit into
masterfrom
fix-user-select

Conversation

@pandadtdyy

@pandadtdyy pandadtdyy commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed redundant update handling in autocomplete selections to properly respect multi-select configuration, preventing unnecessary updates from occurring inappropriately.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 549a1436-f73c-41a1-8130-ef59be3ac893

📥 Commits

Reviewing files that changed from the base of the PR and between bf8c838 and 1af3a89.

📒 Files selected for processing (1)
  • packages/ui-default/components/dialog/index.tsx

Walkthrough

In packages/ui-default/components/dialog/index.tsx, the autocomplete onChange handler inside the prompt component had an early-return condition that prevented updates when the new value matched the currently selected value. This condition has been narrowed to only apply when the field is configured as multi (multi-select). Single-select fields no longer trigger the early return, allowing their onChange to fire even when the same value is reselected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'ui: fix user select dialog change' is too vague and doesn't clearly describe the specific fix being made. It mentions 'fix' and 'user select dialog' but doesn't convey what the actual problem or solution is. Consider using a more specific title that describes the actual fix, such as 'ui: prevent redundant autocomplete updates in multi-select dialogs' to better convey the nature of the change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-user-select

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/ui-default/components/dialog/index.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@undefined-moe undefined-moe merged commit e86fab8 into master Jun 23, 2026
7 checks passed
@undefined-moe undefined-moe deleted the fix-user-select branch June 23, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants