Skip to content

Fix AsyncClient ownership and add WebChannel tests#3

Open
dennisvink wants to merge 1 commit intomainfrom
fix/webchannel-issues-1-2
Open

Fix AsyncClient ownership and add WebChannel tests#3
dennisvink wants to merge 1 commit intomainfrom
fix/webchannel-issues-1-2

Conversation

@dennisvink
Copy link
Copy Markdown
Contributor

This PR resolves #1 and #2.

Changes:

  • track httpx.AsyncClient ownership in WebChannel
  • only close internally-created clients in close()
  • add pytest coverage for handshake, message dispatch, post-response ack/proxy stats, and shutdown ownership behavior
  • add optional test dependency in pyproject.toml

This keeps caller-owned clients alive while adding regression coverage around the affected lifecycle and protocol paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing a WebChannel also closes caller-owned httpx.AsyncClient

1 participant