Repository navigation
Pin bitsandbytes to its floor in the min-versions CI job - #7746
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins
bitsandbytes==0.45.1, the floor declared in #7641, in thetests_min_versionsCI job, so that the quantization tests run against it.Part of #7644.
Depends on
Motivation
The job installs the newest bitsandbytes, so nothing checks that the floor actually works. 0.45.1 only works together with the torch floor: it ships no CUDA 13 binary, and the job currently resolves the newest torch, which is built with CUDA 13 since 2.11, so the quantization tests fail until #7642 pins
torch==2.6.0in this job.Changes
bitsandbytes==0.45.1in thetests_min_versionsjobNote
Low Risk
CI workflow dependency pinning only; no application or runtime code changes.
Overview
Pins
bitsandbytes==0.45.1in thetests_min_versionsGitHub Actions job alongside the other minimum-version constraints (torch==2.6.0, etc.).Previously that job could resolve a newer bitsandbytes, so CI did not verify the declared
>=0.45.1floor. With the floor pinned, quantization-related tests run against the minimum supported bitsandbytes (which pairs with the pinned torch floor rather than a CUDA 13–built newer torch).Reviewed by Cursor Bugbot for commit 9f3034f. Bugbot is set up for automated code reviews on this repo. Configure here.