Repository navigation
Remove the experimental Nash-MD trainer - #7255
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Sep 18, 2026
Member
Author
|
Went through the list against main. Closed three of the six: #6951, #6952 and #6805. Also closed #6821, whose every file was deleted by #7132. The two issues went as "not planned", since the code was removed rather than the bugs fixed. I left the other three open, because each still reproduces in a trainer we kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
trl.experimental.nash_md(NashMDTrainer,NashMDConfig), added in #1853 and moved totrl.experimentalin #4477.Motivation
Reporting the inputs discussed in #7182:
nash-mdandtrltags, and none was created this year. Nobody has spoken up for it in [RFC] Criteria for removing code fromtrl.experimental#7182.GeometricMixtureWrapper, which has no other consumer.NashMDTraineris imported by no major training framework.trl.experimentalsince 2025-11-13, deprecated import path dropped 2026-02-10. Long enough to have been found.Solution
trl.experimentalcarries no stability guarantee, so there is no deprecation cycle. The code stays in the git history.The paper index entry stays and points at the last release that shipped the implementation, following the discussion in #7182.
Changes
NashMDTrainer,NashMDConfigand their testsNashMDTrainerfrom the telemetry allowlistNote
Medium Risk
This is a breaking removal of a public experimental API (
trl.experimental.nash_md); any code still importing it will fail at import time, though usage was reportedly minimal.Overview
Removes the experimental Nash-MD trainer (
NashMDTrainer,NashMDConfig, andGeometricMixtureWrapper) fromtrl.experimental.nash_md, along with its test suite (~580 lines of trainer/config code).Documentation is updated to match: the dedicated trainer page is deleted, and Nash-MD is dropped from the docs toctree, trainer index, dataset-format compatibility table, and vLLM integration examples. The paper index entry for Nash Learning from Human Feedback is kept but now states the implementation shipped only through TRL v1.13 and lives in git history.
NashMDTraineris also removed from the telemetry trainer allowlist inbase_trainer.py. There is no deprecation period becausetrl.experimentalhas no stability guarantee.Reviewed by Cursor Bugbot for commit 39a9e10. Bugbot is set up for automated code reviews on this repo. Configure here.