Skip to content

Compile fixes for Xcode 14.3.1#77

Open
rrva wants to merge 1 commit into
huggingface:mainfrom
rrva:rrva-patch-1
Open

Compile fixes for Xcode 14.3.1#77
rrva wants to merge 1 commit into
huggingface:mainfrom
rrva:rrva-patch-1

Conversation

@rrva

@rrva rrva commented Aug 3, 2023

Copy link
Copy Markdown

Did not compile on Xcode 14.3.1

Cannot convert value of type '()' to expected condition type 'Bool'

Did not compile on Xcode 14.3.1
@rrva

rrva commented Aug 3, 2023

Copy link
Copy Markdown
Author

Fixes #70

@@ -22,8 +22,8 @@ let deviceHas6GBOrMore = ProcessInfo.processInfo.physicalMemory > 5924000000 /

let deviceSupportsQuantization = {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you possibly just also include the implicit declaration of type as well?

let deviceSupportsQuantization: Bool = {

I've had the compiler complain when this was missing a few times as well.

Have you tested that the current code builds in 14.3.1 with the current StableDiffusion package with these changes?

@ghost

ghost commented Aug 7, 2023

Copy link
Copy Markdown

could you possibly just also include the implicit declaration of type as well?

let deviceSupportsQuantization: Bool = {

I've had the compiler complain when this was missing a few times as well.

Have you tested that the current code builds in 14.3.1 with the current StableDiffusion package with these changes?

@dkman94

dkman94 commented Jan 24, 2024

Copy link
Copy Markdown

Had the same issue, and this fixes the problem in 14.3.1 for me as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants