Allow f16/bf16 in custom SDPA - #237
Open
GregoryComer wants to merge 1 commit into
Open
Conversation
GregoryComer
marked this pull request as ready for review
July 9, 2026 00:02
larryliu0820
approved these changes
Jul 9, 2026
Collaborator
|
@GregoryComer LGTM! Can you just rebase your branch on main as the CI is now green there to make sure that all tests pass please? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@GregoryComer The three tests that failed are related to custom SDPA it seems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current module swapped SDPA always runs SDPA in f32, up-converting activations if necessary. We now have native support for half-precision SDPA in ET, so relax the assertions and remove the casts.