Skip to content

Update CARD.md to include install tip when benchmarking#507

Open
alvarobartt wants to merge 1 commit intohuggingface:mainfrom
alvarobartt:main
Open

Update CARD.md to include install tip when benchmarking#507
alvarobartt wants to merge 1 commit intohuggingface:mainfrom
alvarobartt:main

Conversation

@alvarobartt
Copy link
Copy Markdown
Member

Description

This PR updates the CARD.md content that goes into the Hugging Face Hub for the benchmarking section to include the installation instruction with pip including the benchmark extra.

Note that this might be opinionated, so feel free to close if not relevant, I just found that useful when running the benchmarks as I had to pip install kernels -> kernels benchmark ... -> Error: Missing dependencies for benchmark: tabulate\nInstall with: pip install 'kernels[benchmark]' -> pip install "kernels[benchmark]".

Thanks in advance! cc @sayakpaul @danieldk

@sayakpaul
Copy link
Copy Markdown
Member

Oh it should actually be included in the card template so that we don't have to manually update the cards. The template: https://github.com/huggingface/kernels/blob/main/kernel-builder/src/init/templates/CARD.md

@sayakpaul
Copy link
Copy Markdown
Member

Cc: @drbh

@danieldk
Copy link
Copy Markdown
Member

Oh it should actually be included in the card template so that we don't have to manually update the cards. The template: https://github.com/huggingface/kernels/blob/main/kernel-builder/src/init/templates/CARD.md

One of the changes is in the init template, but requires regen of the card templates in the kernel repos.

@alvarobartt
Copy link
Copy Markdown
Member Author

One of the changes is in the init template, but requires regen of the card templates in the kernel repos.

Sure, I can just create a quick script to do so on the kernels at https://huggingface.co/kernels-community/kernels programmatically opening PRs in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants