Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After concatenating a streaming dataset selected with
take(4),set_epoch(1)can change its rows from[0, 1, 2, 3]to[0, 3, 6, 9]. The same problem affectsskip()and explicit shuffling after concatenation.Propagate shuffling through vertical concatenation's shard wrappers so the existing skip/take ordering restriction is honored. This preserves the selected rows while allowing buffer shuffling within that selection. Related to the epoch handling in #8707.
Validation on macOS with Python 3.12 and CPU PyTorch:
make qualityandgit diff --checkpass.The new tests cover Python and Arrow sources, skip/take through a map wrapper, 1/2/4 shards, single/mixed concatenations, repeated epochs and explicit buffered shuffling. Full repository and hosted integration matrices were not run locally.
Implementation and tests were generated with OpenAI Codex; the checks above were executed locally.