Repository navigation
fix(engine): prefer challenge_block over timeout false-hope - #51
Merged
Merged
Conversation
When a nav/timeout exception leaves an inspectable challenge page, classify as challenge_block (no timeout_phase) instead of burning the budget into timeout/work. Hard HTTP blocks abort remaining strategies; soft challenge markers may still retry.
Keep ChallengeAssessment as soft/hard retry owner; lean post-exception inspect skips CDP so hung pages still classify without discarding HTML signals. Shared unclean disposition + thinner challenge fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ChallengeDetectorand returnchallenge_block(notimeout_phase) when unclean.blocked_detectedwithout challenge marker) abort remaining strategies; soft challenge markers may still retry.Why
Root cause
Knowable challenge pages were still classified as
timeout/workafter exceptions, burning wall-clock and showing retry false-hope upstream.Risk
Validation
make check→ exit 0make smokenot run (no Docker/API contract surface change beyond error category timing)