fix(ci): restore fmt and clippy gates under current stable - #9
Merged
Conversation
`cargo fmt --all -- --check` and `cargo clippy -D warnings` both failed on
main under rustc 1.97.1. No source change caused this: `useless_concat` and
`unneeded_struct_pattern` are recent clippy lints, and CI pins nothing.
Three clippy fixes, all in test code and all semantics-preserving:
- codex.rs: two single-argument `concat!(..)` calls collapsed to plain
string literals (clippy::useless_concat).
- ingest_file.rs: `IngestOutcome::Skipped { .. }` -> `IngestOutcome::Skipped`;
it is a unit variant (clippy::unneeded_struct_pattern).
Then `cargo fmt --all`, which rewrapped 18 over-width assertion lines across
the two adapters, adapters/common.rs, and four integration tests. Mechanical
line-wrapping at the 100-column limit only.
No production code touched. Verified green: fmt, clippy (lore-core/lore-ipc
and lore-app), cargo test --locked --all-targets (346 pass / 4 ignored),
no_network_in_archive, no_egress, egress-check.sh, IPC bindings in sync,
npm lint/typecheck/test (148 pass).
Follow-up: pinning the toolchain so this cannot recur.
This was referenced Aug 22, 2026
hsusul
force-pushed
the
fix/ci-unbreak-main
branch
from
August 22, 2026 21:56
e62f248 to
b195364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainis red on two CI gates under rustc 1.97.1:cargo fmt --all -- --check— 18 sitescargo clippy -p lore-core -p lore-ipc --all-targets --all-features -- -D warnings— 3 errorsNo source change caused this.
clippy::useless_concatandclippy::unneeded_struct_patternare recent lint additions, and CI uses unpinneddtolnay/rust-toolchain@stablewith-D warnings, so a toolchain bump breaks the build on its own.Changes
Three clippy fixes, all in test code, all semantics-preserving:
crates/lore-core/src/adapters/codex.rsconcat!(..)→ plain string literaluseless_concatcrates/lore-core/tests/ingest_file.rsIngestOutcome::Skipped { .. }→IngestOutcome::Skipped(unit variant)unneeded_struct_patternThen
cargo fmt --all— 18 over-width assertion lines rewrapped at the 100-column limit across both adapters,adapters/common.rs, and four integration tests. Mechanical only; I reviewed the diff before applying.No production code is touched. Assertion semantics are identical in all three fixes.
Verification
All run locally, exactly as CI invokes them:
cargo fmt --all -- --checkcargo clippy -p lore-core -p lore-ipc --all-targets --all-features -- -D warningscargo clippy -p lore-app --all-targets -- -D warningscargo test --locked -p lore-core -p lore-ipc --all-targetscargo test -p lore-core --test no_network_in_archivecargo test -p lore-app --test no_egress./scripts/egress-check.shnpm run lint/typecheck/testFollow-up
This will recur on the next rustc release. A
rust-toolchain.tomlpin is the next PR in this series.