Repository navigation
perf(char): use lookup tables in match and is_semantic_index - #2246
Merged
Merged
Conversation
Owner
|
thank you. |
njhoffman
pushed a commit
to njhoffman/nvim-cmp
that referenced
this pull request
Nov 6, 2026
…ndex (hrsh7th#2246) (fe29aba) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2240
Summary
char.matchnow uses a 256-entry lowercase table:LOWER[a] == LOWER[b].char.is_semantic_indexreads both bytes with onestring.bytecall and checks thealpha/ALPHA/digittables directly, without going through the helper functions.The public
char.*helpers are unchanged.Data
CPU time, best of 20. Benchmark in #2236.
matcher.matchx60kget_entries, 6k items,isIncompleteget_entries, 20k items,isIncompleteSame results
Checked against the current
char.luaandmatcher.lua:char.match: all byte pairs, includingnilis_semantic_index: all 2-byte strings, index 0..3matcher.match: random words x inputs xmatchingoptions (same score and matches)Testing
All 73 specs pass,
luacheckreports 0 warnings, and touched files are formatted withstylua.