Repository navigation
perf(str): use string.find in str.oneline - #2245
Merged
Merged
Conversation
Owner
|
thank you. |
njhoffman
pushed a commit
to njhoffman/nvim-cmp
that referenced
this pull request
Nov 6, 2026
…0cff98b) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2239
Summary
str.onelinenow usesstring.find(text, '\n', 1, true)instead of a Lua loop over every byte. It also removes the now-unusedNR_BYTEconstant.Data
Time to build entries over 10 keystrokes. CPU time, best of 20. Benchmark in #2236.
isIncompleteisIncompleteGives the same output as before for empty strings, a leading/trailing/repeated
\n, and\r\n.Testing
All 73 specs pass,
luacheckreports 0 warnings, and touched files are formatted withstylua.