Repository navigation
Conversation
njhoffman
added a commit
to njhoffman/nvim-cmp
that referenced
this pull request
Nov 6, 2026
Ports upstream PRs hrsh7th#2243 and hrsh7th#2244: ensure_nil works in place and skips data, which it was altering by stripping vim.NIL values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2238
Summary
ensure_niltakes an optional set of top-level keys to skip.source.luapasses{ data = true }, so the opaqueCompletionItem.datagoes back to the server unchanged oncompletionItem/resolve, as the LSP spec requires. Added a spec case for it.Data
Time to build entries over 10 keystrokes, compared with #2243. CPU time, best of 20. Benchmark in #2236.
isIncompleteisIncompleteBehaviour
nulls insidedataare kept. Every other field is handled as before, including thelabelDetailscase from #2212.Testing
All 73 specs pass,
luacheckreports 0 warnings, and touched files are formatted withstylua.