Repository navigation
perf(view): filter each source once in view.open - #2242
Merged
Merged
Conversation
Owner
|
thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2236
Summary
view.opennow runsget_entriesonce per source and reuses the result, instead of filtering once for the symbol-trigger check and again to collect entries.Data
view.openover 10 keystrokes. CPU time, best of 20. Benchmark in #2236.isIncompleteisIncompleteBehaviour
No change. Scores were already reset by each
get_entriescall, and the source priority is still added once per entry.Testing
All 73 specs pass,
luacheckreports 0 warnings, and touched files are formatted withstylua.