Repository navigation
Conversation
rafaeldev
reviewed
Oct 5, 2026
| } | ||
|
|
||
| private fun initWebAuthentication() { | ||
| if (!Hotwire.config.webAuthenticationEnabled) return |
There was a problem hiding this comment.
How about add a DEBUG log to check early return?
Contributor
Author
There was a problem hiding this comment.
Hm, after thinking more about it, it might be a bit spammy to add a debug log here.
Since this code doesn't run only when webAuthentication is needed, but instead runs every time a WebView is created, and since most people don't use passkeys, I don't think such a debug log would be useful for the majority of devs.
If the code only executed when needed, like for camera or location permissions, I think such a debug log would be a great thing.
leonvogt
force-pushed
the
webauthn-support
branch
2 times, most recently
from
October 6, 2026 13:19
aaf7b50 to
78ff648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of enabling passkey support to our apps, I've noticed that, passkey through the WebView works out-of-the box in iOS, but needs a small tweak in Android.
More specifically, one needs to create a custom WebView to enable
WebSettingsCompat.setWebAuthenticationSupport().This PR would make that obsolete. Hotwire Native will enable web authentication support, if the user opts in via
Hotwire.config.webAuthenticationEnabled.It defaults to
false, same as the WebView itself.For people who read this and are in the process of integrating passkeys:
delegate_permission/common.get_login_creds)android:apk-key-hash:<hash>) rather than the web origin, so the server has to accept that too.