Repository navigation
[HSTG-23533] Fix open Dependabot alerts - #44
Merged
Merged
Conversation
- api-reference: override handlebars to ^4.7.10. hbs@4.3.1, the latest release, still pins handlebars@4.7.9 exactly, so no parent bump exists (GHSA-8r5x-fm3f-whwj, GHSA-p8wg-vrv2-v86f, GHSA-xw65-4hp5-5hc7). - sunday-league: bump @angular/cli to ^21.2.27, which pins @modelcontextprotocol/sdk@1.31.0 (GHSA-6qxp-vccf-f47h). Lockfiles regenerated with npm 10 for the Hostinger deploy platform.
Template previewBuilt each changed template, opened
|
| Expected thumbnail | Actual | Diff |
|---|---|---|
sunday-league
| Expected thumbnail | Actual | Diff |
|---|---|---|
Download screenshots and diffs from this run’s visual-<template> artifacts.
This check fails if install, lint, build, / health, or screenshot diff over the limit fails, or if the PR introduces a high/critical advisory in production dependencies that the base commit did not have (npm audit --omit=dev, head vs base). Pre-existing advisories are listed for information and belong to dependency-update PRs. Limits default to 25% (thumbnail) and 30% (homepage) to absorb Mac-vs-Linux font rasterization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 4 open Dependabot alerts (HSTG-23533).
api-referencehandlebars4.7.9 (runtime, viahbs)api-referencehandlebars4.7.9api-referencehandlebars4.7.9sunday-league@modelcontextprotocol/sdk1.30.0 (dev, via@angular/cli)@angular/cli^21.2.0 → ^21.2.27 (pins 1.31.0)Why an override for handlebars
RULES.mdprefers bumping the parent package.hbs@4.3.1is the latest release and still pinshandlebars@4.7.9exactly, so there's no parent bump to make. The override is documented in the template README, following the pattern from #40. Remove it oncehbsships a newer pin. Dependabot can't open this fix itself because of that exact pin.sunday-leaguegets the parent bump:@angular/cli21.2.26 and later pin@modelcontextprotocol/sdk@1.31.0. Its engines (^20.19.0 || ^22.12.0 || >=24.0.0) still cover the platform's Node 22.Both lockfiles were regenerated with npm 10, as the Hostinger deploy platform requires.
Testing
npm audit:api-referencehas 0 vulnerabilities.sunday-leaguehas 0 high/critical; one pre-existing moderate dev-onlyfast-urifinding remains, see below.api-reference: lint and build pass. I randist/main.jsand requested/plus three/endpoints/*pages. All return 200 and render throughhbswith handlebars 4.7.10. The homepage is byte-for-byte the same size as the live demo.sunday-league: lint and build pass on Angular CLI 21.2.27, anddist/sunday-league/browserserves/with 200.main: I built both templates frommainand from this branch and compared them:api-reference: I crawled every page on both servers (home, all 4 endpoint pages,/endpoints, the 404 page, query-string URLs), 9 in total. All are byte-for-byte identical on handlebars 4.7.9 and 4.7.10, covering all three.hbsviews and both partials.sunday-league: all 11 files indist/sunday-league/browserhave identical hashes. The bump only changes dev tooling, not what's served. The 17.3% / 11.1% screenshot diff in the preview comment is the same as on chore(deps): bump the security group across 13 directories with 8 updates #35 (CI's Linux rendering against the committed screenshots), not a change from this PR.npm ciwith npm 10 on Node 22.Advisories
npm auditstill reportsA repo-wide
npm audit --package-lock-onlyalso flags these. None needs action in this PR:bracesGHSA-vfj7-8cjw-p6xm (high, dev-only, through eslint plugins and Nuxt): every version is affected and no patch exists. Dependabot auto-dismissed it (#618).node-forgeGHSA-86w9-cpqp-85rv (high, Nuxt templates): every version is affected and no patch exists. Already dismissed as tolerable risk (#601).fast-uriGHSA-hrr3-gc8f-f4qj (moderate, dev-only): auto-dismissed (#611). A lockfile-onlynpm audit fixwould clear it in about 20 templates if we want that later.🤖 Generated with Claude Code