feat(form): Add support for PSR-7 file upload to V3 FileVariable and ImageVariable#38
Merged
Merged
Conversation
…ImageVariable When a ServerRequestInterface is passed to BaseForm and files are uploaded, the uploaded files are now extracted via ServerRequestInterface::getUploadedFiles() and injected into variables implementing a new FileUploadAware interface. This eliminates the $_FILES and $GLOBALS['browser'] dependency on the PSR-7 path. These globals however are still supported for legacy fallback. Input via array|Horde_Variables|Variables is unchanged. FormVariables that don't receive an injected UploadedFileInterface continue to read from $_FILES directly. The bridge from lib/ Horde_Form is unaffected since it never calls setUploadedFile(). New: FileUploadAware interface, FileUploadPsr7Test along with 10 tests. Removed: doc/V3-MIGRATION-GUIDE.md obsoleted by UPGRADING.md.
Member
Author
|
Contributes to #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ServerRequestInterface is passed to BaseForm and files are uploaded, the uploaded files are
now extracted via ServerRequestInterface::getUploadedFiles() and injected into variables implementing a new FileUploadAware interface. This eliminates the
$_FILES and $GLOBALS['browser'] dependency on the PSR-7 path. These globals however are still supported for legacy fallback. Input via array|Horde_Variables|Variables is unchanged. FormVariables that don't receive an injected UploadedFileInterface continue to read from $_FILES directly. The bridge from lib/ Horde_Form is unaffected since it never calls setUploadedFile().
New: FileUploadAware interface, FileUploadPsr7Test along with 10 tests.
Removed: doc/V3-MIGRATION-GUIDE.md obsoleted by UPGRADING.md.