Skip to content

Improve connection empty state UI#4557

Merged
bgoncal merged 2 commits intomainfrom
empty-state-ui-improvement
Apr 24, 2026
Merged

Improve connection empty state UI#4557
bgoncal merged 2 commits intomainfrom
empty-state-ui-improvement

Conversation

@bgoncal
Copy link
Copy Markdown
Member

@bgoncal bgoncal commented Apr 24, 2026

Summary

Screenshots

CleanShot 2026-04-24 at 14 38 13@2x

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Apr 24, 2026
Copilot AI review requested due to automatic review settings April 24, 2026 12:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the WebView connection empty-state UI to improve layout and structure, while refactoring related types into separate files for better organization.

Changes:

  • Refactors WebViewEmptyStateStyle and the UIKit WebViewEmptyStateWrapperView into their own files.
  • Reworks WebViewEmptyStateView layout to use safeAreaInset for header and bottom actions.
  • Adds a dedicated previews file with multiple #Preview configurations.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Sources/App/Frontend/WebView/Views/WebViewEmptyStateWrapperView.swift Extracted UIKit wrapper around the SwiftUI empty state view.
Sources/App/Frontend/WebView/Views/WebViewEmptyStateView.swift Updated SwiftUI layout to reposition header/actions using safe-area insets and adjust styling.
Sources/App/Frontend/WebView/Views/WebViewEmptyStateView+Previews.swift Added multiple SwiftUI previews for disconnected/unauthenticated/re-auth flows.
Sources/App/Frontend/WebView/Views/WebViewEmptyStateStyle.swift Extracted empty-state style enum into its own file.
HomeAssistant.xcodeproj/project.pbxproj Adds new files to the project; also includes additional unrelated project-file churn.

Comment thread Sources/App/Frontend/WebView/Views/WebViewEmptyStateView.swift
Comment thread Sources/App/Frontend/WebView/Views/WebViewEmptyStateView.swift
Comment thread HomeAssistant.xcodeproj/project.pbxproj
@bgoncal bgoncal merged commit 1ec9940 into main Apr 24, 2026
12 checks passed
@bgoncal bgoncal deleted the empty-state-ui-improvement branch April 24, 2026 13:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7c852db). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #4557   +/-   ##
======================================
  Coverage        ?       0           
======================================
  Files           ?       0           
  Lines           ?       0           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?       0           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants