Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WebView connection empty-state UI to improve layout and structure, while refactoring related types into separate files for better organization.
Changes:
- Refactors
WebViewEmptyStateStyleand the UIKitWebViewEmptyStateWrapperViewinto their own files. - Reworks
WebViewEmptyStateViewlayout to usesafeAreaInsetfor header and bottom actions. - Adds a dedicated previews file with multiple
#Previewconfigurations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/App/Frontend/WebView/Views/WebViewEmptyStateWrapperView.swift | Extracted UIKit wrapper around the SwiftUI empty state view. |
| Sources/App/Frontend/WebView/Views/WebViewEmptyStateView.swift | Updated SwiftUI layout to reposition header/actions using safe-area insets and adjust styling. |
| Sources/App/Frontend/WebView/Views/WebViewEmptyStateView+Previews.swift | Added multiple SwiftUI previews for disconnected/unauthenticated/re-auth flows. |
| Sources/App/Frontend/WebView/Views/WebViewEmptyStateStyle.swift | Extracted empty-state style enum into its own file. |
| HomeAssistant.xcodeproj/project.pbxproj | Adds new files to the project; also includes additional unrelated project-file churn. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4557 +/- ##
======================================
Coverage ? 0
======================================
Files ? 0
Lines ? 0
Branches ? 0
======================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes