Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes Live Activities settings in the main Settings UI and refactors the Live Activities screen to focus on status + activity samples, removing older privacy/frequent-update footer copy.
Changes:
- Add Live Activities to the main Settings “General” section and mark it as a Labs feature.
- Rework
LiveActivitySettingsViewto include a Samples sub-screen and fold “Frequent Updates” status into the Status section. - Remove now-unused Live Activity privacy and frequent-updates footer localization keys (and SwiftGen accessors).
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/Resources/Swiftgen/Strings.swift | Removes SwiftGen accessors for deleted Live Activity localization keys. |
| Sources/App/Settings/Settings/SettingsView.swift | Shows the Labs badge for the Live Activities settings row. |
| Sources/App/Settings/Settings/SettingsItem.swift | Adds Live Activities to the General settings list; updates Mac Catalyst hidden items list. |
| Sources/App/Settings/LiveActivity/LiveActivitySettingsView.swift | Refactors layout; adds Samples navigation and frequent updates status row; removes privacy/debug sections. |
| Sources/App/Settings/DebugView.swift | Removes the Live Activities link from DebugView. |
| Sources/App/Resources/zh-Hant.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/zh-Hans.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/vi.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/uk.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/tr.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/sv.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/sl.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/ru.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/pt-BR.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/pl-PL.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/nl.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/nb.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/ml.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/ko-KR.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/ja.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/it.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/id.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/hu.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/he.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/fr.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/fi.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/et.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/es.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/es-MX.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/es-ES.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/en.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/en-GB.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/el.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/de.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/da.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/cy-GB.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/cs.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/ca-ES.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
| Sources/App/Resources/bg.lproj/Localizable.strings | Removes unused Live Activity privacy/footer keys. |
Comments suppressed due to low confidence (1)
Sources/App/Settings/LiveActivity/LiveActivitySettingsView.swift:276
startTestActivityrequests an Activity directly withpushType: niland doesn’t go throughCurrent.liveActivityRegistry. However, ending activities in this screen goes through the registry (with only a “first match by tag” fallback), so starting the same sample multiple times can lead to duplicate activities that aren’t reliably ended/updated. Consider usingCurrent.liveActivityRegistry?.startOrUpdate(tag:title:state:)for samples (or otherwise enforce unique tags and consistent start/end paths).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4554 +/- ##
=======================================
Coverage ? 43.46%
=======================================
Files ? 275
Lines ? 17882
Branches ? 0
=======================================
Hits ? 7772
Misses ? 10110
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Keeping it draft while PRs to FCM and Core repos are not merged, since this PR makes live activities settings visible to the end user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes