Skip to content

Move Silicon Labs Flasher source to home-assistant/app-silabs-flasher - #4919

Merged
sairon merged 1 commit into
masterfrom
split-silabs-flasher
Nov 2, 2026
Merged

sairon merged 1 commit into
masterfrom
split-silabs-flasher

Conversation

@sairon

@sairon sairon commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in silabs_flasher/.

Refs #4890

Summary by CodeRabbit

  • New Features
    • Added Silicon Labs Flasher to the app catalog, linked to its new source repository.
  • Changes
    • The local build and startup components for Silicon Labs Flasher have been removed. The app entry now points to the external repository instead.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46fa0687-e65e-414e-8f47-5395cb132381
Commits

Reviewing files that changed from the base of the PR and between b086220 and d0eb020.

Files selected for processing: 15
  • .apps.yml
  • .yamllint
  • silabs_flasher/Dockerfile
  • silabs_flasher/build.yaml
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/banner/dependencies.d/legacy-cont-init
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/banner/type
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/banner/up
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/universal-silabs-flasher/dependencies.d/banner
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/universal-silabs-flasher/type
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/universal-silabs-flasher/up
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/universal-silabs-flasher
  • silabs_flasher/rootfs/etc/s6-overlay/scripts/banner.sh
  • silabs_flasher/rootfs/etc/s6-overlay/scripts/universal-silabs-flasher-up
  • silabs_flasher/rootfs/root/skyconnect_zigbee_ncp_7.4.4.0.gbl
  • silabs_flasher/rootfs/root/yellow_zigbee_ncp_7.4.4.0.gbl
Files with no reviewable changes: 8
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/banner/up
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/universal-silabs-flasher/type
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/universal-silabs-flasher/up
  • silabs_flasher/rootfs/etc/s6-overlay/scripts/banner.sh
  • silabs_flasher/rootfs/etc/s6-overlay/s6-rc.d/banner/type
  • silabs_flasher/rootfs/etc/s6-overlay/scripts/universal-silabs-flasher-up
  • silabs_flasher/build.yaml
  • silabs_flasher/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The repository registers silabs_flasher with an external app repository. It removes the local Docker build configuration and s6 startup files, and adds the app configuration path to the yamllint ignore list.

Changes: Silabs Flasher app registration

Layer / File(s) Summary
Register the external app
.apps.yml, .yamllint
.apps.yml adds the external repository, target, and image names for silabs_flasher. .yamllint adds /silabs_flasher/config.yaml to its ignore list.
Remove the local build and startup implementation
silabs_flasher/Dockerfile, silabs_flasher/build.yaml, silabs_flasher/rootfs/etc/s6-overlay/...
The local Dockerfile, build configuration, s6 service declarations, and banner and flasher startup scripts are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: agners

Merge Risk: Minimal · previous review d0eb0

The external app registration can merge without an established build, lint, discovery, or installation failure.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: moving the Silicon Labs Flasher source to home-assistant/app-silabs-flasher while retaining app index metadata.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Keep only the app index metadata in silabs_flasher/.

Refs #4890
@sairon
sairon force-pushed the split-silabs-flasher branch from d0eb020 to baabe71 Compare November 2, 2026 14:52
@sairon
sairon merged commit 30f5d23 into master Nov 2, 2026
7 checks passed
@sairon
sairon deleted the split-silabs-flasher branch November 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants