Skip to content

Make “Tag der Befreiung” reoccur in Berlin in 2025#293

Open
michaelem wants to merge 54 commits into
holidays:masterfrom
projo-berlin:master
Open

Make “Tag der Befreiung” reoccur in Berlin in 2025#293
michaelem wants to merge 54 commits into
holidays:masterfrom
projo-berlin:master

Conversation

@michaelem

Copy link
Copy Markdown

@rpellerin

Copy link
Copy Markdown

Hello @ppeble, could this PR be merged please? ☺️
Thank you!

@chrp

chrp commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@ppeble Could you please merge this PR?

@DagonWat

Copy link
Copy Markdown
Contributor

Hi @ppeble, I know this change is late, but I think its still worth to merge to keep historical data valid.

@ppeble

ppeble commented Apr 27, 2026

Copy link
Copy Markdown
Member

I apologize for the atrocious delay. If you resolve the conflicts I will happily merge and get it released in the gem.

@DagonWat

Copy link
Copy Markdown
Contributor

Hello @michaelem could you please resolve the conflicts? Alternatively I can hop on this topic on weekend and create new PR from my fork of yours work.

@michaelem

Copy link
Copy Markdown
Author

@DagonWat @ppeble resolved!

@ppeble

ppeble commented Apr 30, 2026

Copy link
Copy Markdown
Member

@michaelem All looks good, just need DCO to pass! Once you get it passing I will merge.

@DagonWat

Copy link
Copy Markdown
Contributor

@michaelem its basically that you need to sign your commits to get them to master, you can see more on this failed check page - https://github.com/holidays/definitions/pull/293/checks?check_run_id=73676321170

michaelem and others added 19 commits June 22, 2026 11:33
Updated holiday dates and sources for Slovak holidays in the Ruby Holiday gem.

Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
UPS is observing Martin Luther King Jr. Day as of 2024:

https://www.ups.com/us/en/support/shipping-support/shipping-services/holiday-shipping-schedule.page
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Add the new holidays in ro.yaml:
- Botezul Domnului - Boboteaza
- Soborul Sfântului Proroc Ioan Botezătorul

Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
abenhamdine and others added 26 commits June 22, 2026 11:33
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
…o 6.1.1

Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
…lidays

Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
…y of November

Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
…ys#177)

Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
…nday

Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Michael Emhofer <michael.emhofer@projo.berlin>
@michaelem

Copy link
Copy Markdown
Author

@ppeble @DagonWat found the time to re-word the commit (challenged my git knowledge given how much has happened since the original commit). CI is now green but you need to re-review this commit to accept last year's holiday into your gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.