Failing tests for put edgecases#39
Merged
Merged
Conversation
lejeunerenard
requested changes
Apr 17, 2026
lejeunerenard
left a comment
lejeunerenard
left a comment
Contributor
There was a problem hiding this comment.
Thank you for finding the bug! Fix is in #43.
Co-authored-by: Sean Zellmer <sean@lejeunerenard.com>
Co-authored-by: Sean Zellmer <sean@lejeunerenard.com>
…cases # Conflicts: # test/basic.js
lejeunerenard
approved these changes
Apr 18, 2026
lejeunerenard
left a comment
lejeunerenard
left a comment
Contributor
There was a problem hiding this comment.
Ready to go after fix is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first one might be undefined behaviour, if only buffer values are supported.
The second one is quite worrying: behaviour shouldn't change after re-opening storage.
A trivial fix is adding a guard here:
hyperbee2/lib/write.js
Line 171 in be37588