Refactor of Hyperbee._rollback()#22
Open
caolan wants to merge 2 commits into
Open
Conversation
There were numerous comparisons of `expected === this.unbatch` which were unnecessary. Reduced number of variables by tracking only `seq` and not `length`. TODO: review whether attempting to rollback more write batches than exist in the core should be an error case.
caolan
force-pushed
the
rollback-refactor
branch
from
32f6257 to
5c4da0a
Compare
Contributor
|
thanks @caolan i think it looks great |
Contributor
|
re your q, i dont think it needs to be an error case, we can be forgiving here for now |
Contributor
|
can you update comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion.
There were numerous comparisons of
expected === this.unbatchwhich were unnecessary. Reduced number of variables by tracking onlyseqand notlength.TODO: Before merging, review whether attempting to rollback more write batches than exist in the core should be an error case.