Skip to content

http: Upgrade components signatues to use std::experimental::string_view#42

Open
RicoAntonioFelix wants to merge 1 commit into
hioa-cs:masterfrom
RicoAntonioFelix:string_view_interface
Open

http: Upgrade components signatues to use std::experimental::string_view#42
RicoAntonioFelix wants to merge 1 commit into
hioa-cs:masterfrom
RicoAntonioFelix:string_view_interface

Conversation

@RicoAntonioFelix

@RicoAntonioFelix RicoAntonioFelix commented Nov 30, 2016

Copy link
Copy Markdown
Member

API Changes

  • All standard header fields are now placed under http::header_fields with fields names in common case
  • http:extension_to_type -> http::ext_to_mime_type
  • make_request(buffer_t, const size_t) -> make_request(std::string)
  • Request_line::get_method -> Request_line::method
  • Request_line::get_uri -> Request_line::uri
  • Request_line::get_version -> Request_line::version
  • Status_line::get_code -> Status_line::code
  • Status_line::get_version -> Status_line::version
  • Version::get_minor -> Version::minor
  • Version::get_major -> Version::major

@alfreb

alfreb commented Dec 1, 2016

Copy link
Copy Markdown
Member

@RicoAntonioFelix string view sounds like a great idea! How far away is this interface from includeos/http and Acorn integration? Would be great to make the switch.

@RicoAntonioFelix

RicoAntonioFelix commented Dec 1, 2016

Copy link
Copy Markdown
Member Author

@alfred-bratterud I've updated the PR to outline the breaking API changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants