fix(cli): respect registry compatibility metadata#1251
Open
kiyeonjeon21 wants to merge 1 commit into
Open
Conversation
miguel-heygen
approved these changes
Jun 7, 2026
Collaborator
|
sign the commit pls to merge it |
838f612 to
f24c54f
Compare
Contributor
Author
|
Done, signed and force-pushed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds CLI-side handling for registry item compatibility metadata that is already part of the registry item schema:
minCliVersionhyperframes addand the interactive catalog install pathWhy
Registry items can declare
deprecatedandminCliVersion, buthyperframes addcurrently installs them without checking those fields. That can lead to confusing installs when an item depends on newer CLI behavior or has been superseded.How
deprecatedandminCliVersionchecks0.0.0-dev) unblocked for local developmentregistryDependenciesresolution out of scope for this changeTest plan
Commands run:
bun run --filter @hyperframes/cli test src/registry/compatibility.test.ts src/commands/add.test.tsbun run --filter @hyperframes/cli typecheckbunx oxlint packages/cli/src/registry/compatibility.ts packages/cli/src/registry/compatibility.test.ts packages/cli/src/commands/add.ts packages/cli/src/commands/add.test.ts packages/cli/src/commands/catalog.tsbunx oxfmt --check packages/cli/src/registry/compatibility.ts packages/cli/src/registry/compatibility.test.ts packages/cli/src/commands/add.ts packages/cli/src/commands/add.test.ts packages/cli/src/commands/catalog.tsbunx fallow audit --base upstream/main --fail-on-issues