Chore/sibujs quality followups#39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the test coverage that the duplicate-instance hardening shims reduced — pure test/coverage work, no behavior change.
The
globalThisfirst-copy-wins registries added for duplicate-runtime resilience have a "a duplicate copy loaded" branch that the normal suite can't reach (the source module evaluates exactly once, always taking the first-copy path), which lefttrack.tsat 33% branch andbatch.tsat 90%.tests/duplicate-instance-source.test.ts— covers the duplicate-detection path on the real source modules by pre-seeding theglobalThisregistry as if a first copy had published its API, then freshly importing the module so its resolver executes the duplicate branch (delegates to the first copy, dev-warns once, batch re-exports the first copy's functions)./* v8 ignore */on the__SIBU_VERSION__build-define branch intrack.ts(only inlined by the bundler, never reachable in source tests — matches the existing__SIBU_DEV__pattern indev.ts).Result:
track.tsandbatch.tsare back to 100% across all metrics. Full suite: 321 files / 3954 tests pass.Related Issue
Closes #
Type of Change
(Test coverage / chore — none of the above categories apply; no production behavior change.)
Checklist