Audit/full audit#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Full audit-and-improve cycle for the SibuJS core framework, covering integrity, performance, security, documentation, and test coverage.
Correctness & security fixes
preloadModule; routed resource-hint hrefs (preloadModule/preloadResource/prefetch) throughsanitizeUrl; hardened testing-helper selectors with quote/backslash escaping.watch/store.subscribe/store.subscribeKeycallbacks now run untracked (no dependency leaks); reactivesrcsetconsolidated to a single shared sanitization policy (static + reactive paths can no longer drift).Performance
sanitizeCSSValuefast-path (7.4×),tagFactoryblocked-tag precompute (4.2×), and removal of per-notification closure allocations inwatch/store.Cleanup & docs
bench.mjslist-render callback.when/matcheager-branch-read gotcha (code JSDoc + AGENTS.md "Common mistakes").sibujs-webAGENTS.md: added the requiredsibujs-ui/themes/base.cssimport instruction and corrected the available-themes list.Test coverage: 92.41% → 98.70%
core,reactivity,browser,utilsnow at 100%; every feature dir at 96–99%.IMPROVEMENTS.mdtracks remaining work (router concurrency/abort internals, async-cache races) where literal 100% would trade flakiness for marginal gain.Related Issue
Closes #
Type of Change
Checklist