feat(plugin-js): js_typecheck driver, per-package tsc - #363
Closed
raphaelvigee wants to merge 1 commit into
Closed
Conversation
raphaelvigee
force-pushed
the
raphaelvigee/feat-plugin-js-m3-typecheck
branch
from
August 7, 2026 11:21
9bdf419 to
6627d07
Compare
raphaelvigee
marked this pull request as ready for review
August 7, 2026 12:57
raphaelvigee
force-pushed
the
raphaelvigee/feat-plugin-js-m3-typecheck
branch
from
August 7, 2026 12:58
6627d07 to
93c5768
Compare
raphaelvigee
force-pushed
the
raphaelvigee/feat-plugin-js-m3-typecheck
branch
2 times, most recently
from
August 7, 2026 18:31
8e3c894 to
861c985
Compare
M3 of the JS/TS plugin: a cacheable js_typecheck ManagedDriver running tsc --noEmit per package, fed by the M2 import graph rather than blind package.json declarations. - Toolchain: tstool=host (only supported mode) resolves tsc from node_modules/.bin or PATH, queried once per Provider lifetime and hashed alongside the tsconfig content — disclosed non-hermetic escape hatch, same shape as the design doc's stated M1+ gap. - Input scoping fixed through review to actually match what tsc reads: plain (non-type-only) cross-package imports, not just `import type`; third-party .d.ts inputs resolved via the same lockfile mechanism as js_install (works with no ambient node_modules, not just when one happens to exist on disk); tsconfig include/exclude honored for first-party sources; the full tsconfig extends chain declared and hashed; a shared/ancestor tsconfig with unscoped include is now a loud Provider::get error instead of a silently unsound cache key. Reviewed by feature-quality/code-quality/hermeticity — five BLOCKERs found (all variations on "the declared Input set doesn't match what tsc actually reads") and fixed, each with a regression test proving the specific divergence. Tests requiring a real tsc binary are #[ignore]d with a named reason rather than silently skipping and reading as a pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3wZfyPsG8stfRQuybLRjN
raphaelvigee
force-pushed
the
raphaelvigee/feat-plugin-js-m3-typecheck
branch
from
August 7, 2026 19:56
861c985 to
c76de6b
Compare
Member
Author
|
Superseded by #370 — the whole stack was squash-collapsed into a single PR rebased on master, per request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M3 of the JS/TS heph plugin plan (part 3/6 of the stack).
A cacheable js_typecheck ManagedDriver running
tsc --noEmitper package, fed by the M2 import graph rather than blind package.json declarations.import type; third-party .d.ts inputs resolved via the same lockfile mechanism as js_install; tsconfig include/exclude honored; the full tsconfig extends chain declared and hashed; a shared/ancestor tsconfig with unscoped include is now a loud Provider::get error instead of a silently unsound cache key.Reviewed by feature-quality/code-quality/hermeticity — five BLOCKERs found (all variations on "the declared Input set doesn't match what tsc actually reads") and fixed, each with a regression test proving the specific divergence. Tests requiring a real tsc binary are #[ignore]d with a named reason rather than silently skipping and reading as a pass.
Test plan
Stack created with GitHub Stacks CLI • Give Feedback 💬