Repository navigation
feat: add support for custom header sanitization and redaction - #37
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Add support for redacting specific headers with [REDACTED] and configuring custom header sanitization functions on Logger. - Add SanitizeHeader and RedactHeaders methods to Logger, as well as the SanitizeHeaders struct field, to redact designated headers with [REDACTED]. - Add SetHeaderSanitizer method and HeaderSanitizer struct field to Logger to allow user-defined sanitization logic per header name/value, with safe panic recovery and fallback to default sanitizers. - Export standard sanitizers (AuthorizationSanitizer, CookieSanitizer, and SetCookieSanitizer) from internal/header so users can easily reuse them. - Add regression tests in logger_test.go. Fixes henvic#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, httpretty automatically sanitizes default sensitive headers (Authorization, Proxy-Authorization, Cookie, and Set-Cookie) using fixed block characters, but callers cannot configure custom headers for redaction or provide custom sanitization routines without completely bypassing sanitization via SkipSanitize. Because the underlying internal/header package is internal, external callers also cannot reuse standard sanitizers.
This change introduces configurable header sanitization and redaction options on Logger.
Details
Fixes #14