Repository navigation
fix: print TLS connection information before HTTP request headers - #36
Open
AdamMagued wants to merge 2 commits into
Open
AdamMagued wants to merge 2 commits into
AdamMagued wants to merge 2 commits into
Conversation
When logging outgoing HTTP traffic with TLS enabled, TLS connection and server certificate details were previously printed after the request headers. Buffer outgoing request output when TLS logging is enabled so that TLS connection state and server certificate details can be emitted before the request header block once established, matching the chronological order observed on incoming server traffic. Update golden test fixtures and add TestOutgoingTLSPrintOrder to verify order across flush strategies. Fixes henvic#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When logging outgoing HTTP traffic with TLS enabled, TLS connection details and server certificates were printed after the request headers block during the response phase.
This change adjusts RoundTrip logging:
Fixes #1